Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/core): add missing Series.shortTitle typing #5860

Merged
merged 1 commit into from Dec 29, 2022

Conversation

euljr
Copy link
Contributor

@euljr euljr commented Dec 22, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Following update for #5836

Description of Changes Made (if issue reference is not provided)

Hello Cube team 👋 ,

When testing, I was using only the .seriesNames and didn't notice that the .series method had a separate return type, so I missed adding the shortTitle property typing in the Series.

This PR adds this missing type.

Thank you so much for reviewing the other PR, and sorry for the mistake.

I don't think this needs to be merged soon (seriesNames is enough on our side), this typing will solve the other issue by exposing it correctly though.

@euljr euljr requested a review from a team as a code owner December 22, 2022 10:49
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Dec 22, 2022
@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 82.13% // Head: 41.05% // Decreases project coverage by -41.07% ⚠️

Coverage data is based on head (8698b46) compared to base (5f63c02).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5860       +/-   ##
===========================================
- Coverage   82.13%   41.05%   -41.08%     
===========================================
  Files         139      149       +10     
  Lines       18910    19553      +643     
  Branches        0     5090     +5090     
===========================================
- Hits        15532     8028     -7504     
- Misses       3378    10705     +7327     
- Partials        0      820      +820     
Flag Coverage Δ
cube-backend 41.05% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/cubesql/pg-srv/src/buffer.rs
...cubesql/cubesql/src/compile/rewrite/rules/split.rs
rust/cubesql/cubesql/src/sql/postgres/shim.rs
.../models/v1_load_request_query_filter_logical_or.rs
rust/cubesql/cubesql/src/bin/cubesqld.rs
.../cubesql/cubeclient/src/models/v1_meta_response.rs
...ile/engine/information_schema/postgres/pg_stats.rs
...ine/information_schema/postgres/testing_dataset.rs
rust/cubesql/cubesql/src/compile/error.rs
...engine/information_schema/postgres/pg_attribute.rs
... and 278 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vasilev-alex vasilev-alex merged commit 5dd78b9 into cube-js:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants