fix(@cubejs-client/core): add missing Series.shortTitle typing #5860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Following update for #5836
Description of Changes Made (if issue reference is not provided)
Hello Cube team 👋 ,
When testing, I was using only the
.seriesNames
and didn't notice that the.series
method had a separate return type, so I missed adding theshortTitle
property typing in the Series.This PR adds this missing type.
Thank you so much for reviewing the other PR, and sorry for the mistake.
I don't think this needs to be merged soon (
seriesNames
is enough on our side), this typing will solve the other issue by exposing it correctly though.