Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultSet.totalRow is converting non-date fields to Dates since v0.19.9 #602

Closed
JeffreyPalmer opened this issue Apr 20, 2020 · 4 comments
Closed
Labels
bug Something isn't working
Milestone

Comments

@JeffreyPalmer
Copy link

Describe the bug
The client ResultSet.totalRow function is converting values that are not dates into dates.

For example, a result of "5138" used to be 5138, but it is now the date: "Date Fri Dec 31 5137 16:00:00 GMT-0800 (Pacific Standard Time)". I am guessing that this commit is the cause.

To Reproduce
Steps to reproduce the behavior:

  1. Return a result that includes a number (in my case it was a "count" measure).
  2. Access the result via the ResultSet.totalRow function
  3. Your field has been erroneously converted into a Date.

Expected behavior
Non-dates should not become dates.

Screenshots
If applicable, add screenshots to help explain your problem.

Version:
0.19.9

@JeffreyPalmer JeffreyPalmer changed the title totalRow is converting non-date fields to Dates since v0.19.9 ResultSet.totalRow is converting non-date fields to Dates since v0.19.9 Apr 20, 2020
@paveltiunov paveltiunov added the bug Something isn't working label Apr 20, 2020
@paveltiunov
Copy link
Member

@JeffreyPalmer Hey Jeffrey! Thanks for posting this! Seems like invalid regex. cc @richipargo

@paveltiunov
Copy link
Member

@JeffreyPalmer Should be fixed in 0.19.11. Could you please update and check?

@paveltiunov paveltiunov added this to the v0.19.11 milestone Apr 20, 2020
@richipargo
Copy link
Contributor

Just saw this @paveltiunov thanks for the quick adjustement, probably will have to take a more in depth look

@JeffreyPalmer
Copy link
Author

Yep, this is fixed. Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants