Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubejs-client-core): Remove Content-Type header from requests in HttpTransport #709

Merged
merged 2 commits into from Jun 10, 2020

Conversation

oguzbilgener
Copy link
Contributor

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#688

Description of Changes Made

…HttpTransport

Currently all methods make GET requests, so there is no body content to indicate a type for.

Fixes cube-js#688
@codecov-commenter
Copy link

Codecov Report

Merging #709 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          40       40           
  Lines        3319     3319           
=======================================
  Hits         2679     2679           
  Misses        640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a3527...9faaa3e. Read the comment docs.

@vasilev-alex vasilev-alex merged commit f6e366c into cube-js:master Jun 10, 2020
@oguzbilgener oguzbilgener deleted the fix-get-headers branch June 13, 2020 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants