Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add schema path as an environment variable. #711

Merged
merged 1 commit into from Jun 10, 2020

Conversation

magno32
Copy link
Contributor

@magno32 magno32 commented Jun 10, 2020

fixes #695

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #695

Description of Changes Made (if issue reference is not provided)

This change adds CUBEJS_SCHEMA_PATH as an environment variable parameter for the schema path. Precedence is options.schemaPath -> process.env.CUBEJS_SCHEMA_PATH -> 'schema.

I did not see the environment variables documented anywhere, so I did not add this to the documentation.

@codecov-commenter
Copy link

Codecov Report

Merging #711 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #711   +/-   ##
=======================================
  Coverage   80.71%   80.71%           
=======================================
  Files          40       40           
  Lines        3319     3319           
=======================================
  Hits         2679     2679           
  Misses        640      640           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 778df72...a8d04a5. Read the comment docs.

@vasilev-alex vasilev-alex merged commit 5ee2e16 into cube-js:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting schemaPath via environment
3 participants