New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground look-n-feel #1200
Playground look-n-feel #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure if we need to mix the styled components
approach and less
(considering it's used in few places). I guess we could use https://styled-components.com/docs/api#createglobalstyle
LGTM otherwise
export default RemoveButtonGroup; | ||
const styledRemoveButtonGroup = styled(RemoveButtonGroup)` | ||
&& { | ||
border: 1px solid ${vars.primaryColor}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, this should be done using theming https://styled-components.com/docs/advanced#theming
Discussed & fixed. Ready to merge. |
New design for the playground.