Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RedisPool issue with broken release on exception #2575

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ovr
Copy link
Member

@ovr ovr commented Apr 19, 2021

refs #2574

@ovr ovr force-pushed the redis-pool-release-issue branch from 54e93f6 to 2af02a4 Compare April 19, 2021 15:04
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Base: 57.23% // Head: 57.30% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (1855c05) compared to base (f538d43).
Patch coverage: 69.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
+ Coverage   57.23%   57.30%   +0.07%     
==========================================
  Files         115      115              
  Lines        8659     8657       -2     
  Branches     1894     1894              
==========================================
+ Hits         4956     4961       +5     
+ Misses       3362     3355       -7     
  Partials      341      341              
Impacted Files Coverage Δ
...-orchestrator/src/orchestrator/LocalQueueDriver.js 95.18% <ø> (ø)
...-orchestrator/src/orchestrator/RedisCacheDriver.ts 3.03% <0.00%> (ø)
...s-query-orchestrator/src/orchestrator/RedisPool.ts 13.63% <0.00%> (ø)
...-orchestrator/src/orchestrator/RedisQueueDriver.js 3.03% <0.00%> (+0.04%) ⬆️
...-query-orchestrator/src/orchestrator/QueryQueue.js 88.82% <96.15%> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 52.79% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovr ovr force-pushed the redis-pool-release-issue branch from 2af02a4 to 1855c05 Compare April 19, 2021 15:21
@ifokeev
Copy link

ifokeev commented Apr 20, 2021

had problems with this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants