Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add minio support #2661

Closed
wants to merge 6 commits into from

Conversation

rongfengliang
Copy link
Contributor

@rongfengliang rongfengliang commented May 6, 2021

Issue Reference this PR resolves

Add minio S3-Compatible storage #2642

env config

CUBESTORE_SERVER_NAME=localhost:9999
CUBESTORE_META_PORT=9999
CUBESTORE_S3_BUCKET=<bucket>
CUBESTORE_S3_ENDPOINT=<minio endpoint>
CUBESTORE_S3_REGION=<minio default region us-east-1>
CUBESTORE_S3_PATH_STYLE=1 // this  need pass  for support path style access 
CUBESTORE_AWS_ACCESS_KEY_ID=<>
CUBESTORE_AWS_SECRET_ACCESS_KEY=<>

@rongfengliang rongfengliang requested a review from a team as a code owner May 6, 2021 05:54
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label May 6, 2021
@paveltiunov
Copy link
Member

Hey @rongfengliang ! Thanks for contributing it! Looks great! The only thing is I'd rather introduce a separate set of env like and make path style implicit

CUBESTORE_MINIO_BUCKET=<bucket>
CUBESTORE_MINIO_ENDPOINT=<minio endpoint>
CUBESTORE_MINIO_ACCESS_KEY_ID=<>
CUBESTORE_MINIO_SECRET_ACCESS_KEY=<>

A test for this one would be highly appreciated.

@rongfengliang
Copy link
Contributor Author

@paveltiunov ok. i will try to change it. A bit busy at the moment

@ilya-biryukov ilya-biryukov removed their assignment Nov 18, 2021
@paveltiunov
Copy link
Member

Was provided in #3738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants