Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@cubejs-client/core): fix HTTP poll not working if Cube API stops and recovers #3506

Merged
merged 1 commit into from Apr 26, 2022

Conversation

rongfengliang
Copy link
Contributor

fix http subscribe poll not working #3493

fix http  subscribe poll not working cube-js#3493
@rongfengliang rongfengliang requested a review from a team as a code owner October 2, 2021 13:53
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 2, 2021
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #3506 (9ff63fd) into master (c1b2e10) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
- Coverage   59.82%   59.77%   -0.06%     
==========================================
  Files         124      124              
  Lines        9946     9946              
  Branches     2253     2253              
==========================================
- Hits         5950     5945       -5     
- Misses       3710     3715       +5     
  Partials      286      286              
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 64.00% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b2e10...9ff63fd. Read the comment docs.

@hassankhan hassankhan changed the title fix http poll will not running if cube.js api server stop and then recovery fix(@cubejs-client/core): fix HTTP poll not working if Cube API stops and recovers Dec 20, 2021
@paveltiunov paveltiunov merged commit c207c3c into cube-js:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants