Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timestamp for quarter range in time series #4162

Merged
merged 1 commit into from Mar 3, 2022

Conversation

Yashkochar20
Copy link
Contributor

@Yashkochar20 Yashkochar20 commented Mar 2, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

NA

Description of Changes Made (if issue reference is not provided)

Time range for quarter is wrong and not in sync with week, day timeseries timestamp range

@Yashkochar20 Yashkochar20 requested a review from a team as a code owner March 2, 2022 21:58
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #4162 (2c61f6d) into master (ee496b3) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4162      +/-   ##
==========================================
- Coverage   58.82%   58.73%   -0.10%     
==========================================
  Files         133      133              
  Lines       10846    10846              
  Branches     2558     2558              
==========================================
- Hits         6380     6370      -10     
- Misses       4186     4196      +10     
  Partials      280      280              
Flag Coverage Δ
cube-backend 58.73% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/cubejs-backend-shared/src/time.ts 28.57% <100.00%> (ø)
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 63.78% <0.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61a9fab...2c61f6d. Read the comment docs.

@paveltiunov
Copy link
Member

Hey @Yashkochar20 ! Thanks for contributing it! Looks good to me!

@paveltiunov paveltiunov merged commit 8e27ae7 into cube-js:master Mar 3, 2022
@Yashkochar20
Copy link
Contributor Author

Thank you @paveltiunov , really appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants