Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support snake case security_context in COMPILE_CONTEXT #6519

Conversation

keydunov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@keydunov keydunov requested a review from a team as a code owner April 30, 2023 18:49
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (9863c35) 47.23% compared to head (49d6cba) 47.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6519      +/-   ##
==========================================
+ Coverage   47.23%   47.24%   +0.01%     
==========================================
  Files         154      154              
  Lines       20312    20316       +4     
  Branches     5237     5238       +1     
==========================================
+ Hits         9594     9598       +4     
  Misses       9879     9879              
  Partials      839      839              
Flag Coverage Δ
cube-backend 47.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...schema-compiler/src/compiler/DataSchemaCompiler.js 54.45% <100.00%> (+0.92%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov changed the title chore: Support snake case security_context in COMPILE_CONTEXT feat: Support snake case security_context in COMPILE_CONTEXT May 1, 2023
@keydunov keydunov merged commit feb3fe3 into master May 1, 2023
28 checks passed
@keydunov keydunov deleted the SL-72-support-security-context-snake-case-style-in-compile-context branch May 1, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants