Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(databricks-jdbc-driver): Return NULL decimal as NULL instead of 0 #6768

Merged
merged 16 commits into from
Jun 30, 2023

Conversation

paveltiunov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested review from a team as code owners June 27, 2023 19:16
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.02 🎉

Comparison is base (6cae9b5) 47.30% compared to head (3811908) 47.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6768      +/-   ##
==========================================
+ Coverage   47.30%   47.33%   +0.02%     
==========================================
  Files         155      155              
  Lines       20428    20430       +2     
  Branches     5285     5158     -127     
==========================================
+ Hits         9664     9670       +6     
- Misses       9923    10444     +521     
+ Partials      841      316     -525     
Flag Coverage Δ
cube-backend 47.33% <50.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ubejs-schema-compiler/src/compiler/YamlCompiler.ts 71.25% <50.00%> (-0.27%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paveltiunov paveltiunov requested a review from a team as a code owner June 30, 2023 02:07
@paveltiunov paveltiunov merged commit c2ab19d into master Jun 30, 2023
34 checks passed
@paveltiunov paveltiunov deleted the databricks-null-sum-fix branch June 30, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant