Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native): More concise module structure #7180

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Sep 30, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@paveltiunov paveltiunov requested a review from a team as a code owner September 30, 2023 19:43
@vercel
Copy link

vercel bot commented Sep 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2023 8:39pm

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d345d74) 71.21% compared to head (9ce705c) 71.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7180      +/-   ##
==========================================
- Coverage   71.21%   71.20%   -0.01%     
==========================================
  Files         323      323              
  Lines       53748    53748              
  Branches     5216     5216              
==========================================
- Hits        38274    38270       -4     
- Misses      15155    15159       +4     
  Partials      319      319              
Flag Coverage Δ
cube-backend 47.06% <100.00%> (ø)
cubesql 86.37% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...schema-compiler/src/compiler/DataSchemaCompiler.js 54.38% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov requested a review from a team as a code owner September 30, 2023 20:39
@paveltiunov paveltiunov merged commit e2a80bf into master Sep 30, 2023
59 checks passed
@paveltiunov paveltiunov deleted the python-module-structure branch September 30, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant