Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct GraphQL endpoint displayed on front-end #7226

Conversation

peterklingelhofer
Copy link
Contributor

@peterklingelhofer peterklingelhofer commented Oct 14, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

GraphQL endpoint has been incorrect here for a while.

Description of Changes Made (if issue reference is not provided)

Removed the /v1 in front of /graphql so we render the correct endpoint.

@peterklingelhofer peterklingelhofer requested a review from a team as a code owner October 14, 2023 20:29
@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2023 8:30pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 14, 2023
@paveltiunov paveltiunov changed the title bugfix: Correct GraphQL endpoint displayed on front-end fix: Correct GraphQL endpoint displayed on front-end Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b08e27b) 47.05% compared to head (d3a8cfb) 47.05%.
Report is 32 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7226   +/-   ##
=======================================
  Coverage   47.05%   47.05%           
=======================================
  Files         155      155           
  Lines       20752    20752           
  Branches     5219     5219           
=======================================
  Hits         9765     9765           
  Misses      10669    10669           
  Partials      318      318           
Flag Coverage Δ
cube-backend 47.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 4ae0f18 into cube-js:master Oct 25, 2023
35 of 36 checks passed
@peterklingelhofer peterklingelhofer deleted the bugfix/correct-graphql-endpoint-front-end branch October 25, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants