Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@cubejs-client/core): expose total rows (#7140) #7372

Merged
merged 1 commit into from Nov 11, 2023

Conversation

hannosgit
Copy link
Contributor

@hannosgit hannosgit commented Nov 4, 2023

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[#7140]

@hannosgit hannosgit requested a review from a team as a code owner November 4, 2023 10:18
Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2023 10:18am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 4, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac2bf15) 71.17% compared to head (2ebaaa7) 47.06%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7372       +/-   ##
===========================================
- Coverage   71.17%   47.06%   -24.11%     
===========================================
  Files         324      155      -169     
  Lines       54016    20779    -33237     
  Branches     5353     5353               
===========================================
- Hits        38445     9780    -28665     
+ Misses      14723    10151     -4572     
  Partials      848      848               
Flag Coverage Δ
cube-backend 47.06% <ø> (+0.02%) ⬆️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr requested a review from vasilev-alex November 9, 2023 22:25
@paveltiunov paveltiunov merged commit a4d08c9 into cube-js:master Nov 11, 2023
35 of 36 checks passed
@hannosgit hannosgit deleted the client-core-total-rows branch November 11, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants