Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubestore-driver): Import - check introspection results #7382

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Nov 6, 2023

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner November 6, 2023 18:17
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 10:23pm

@ovr ovr force-pushed the fix/cubestore-driver-check-headers branch from cdb7a7c to e01f3fc Compare November 6, 2023 18:19
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3e1389b) 47.09% compared to head (b6ff88d) 47.01%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7382      +/-   ##
==========================================
- Coverage   47.09%   47.01%   -0.08%     
==========================================
  Files         155      155              
  Lines       20809    20809              
  Branches     5356     5356              
==========================================
- Hits         9800     9784      -16     
- Misses      10161    10177      +16     
  Partials      848      848              
Flag Coverage Δ
cube-backend 47.01% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the fix/cubestore-driver-check-headers branch from e01f3fc to b6ff88d Compare November 9, 2023 22:22
@ovr ovr changed the title fix(cubestore-driver): Import - check that columns exist fix(cubestore-driver): Import - check introspection results Nov 9, 2023
@ovr ovr merged commit a8b8ad0 into master Nov 9, 2023
22 of 23 checks passed
@ovr ovr deleted the fix/cubestore-driver-check-headers branch November 9, 2023 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant