fix(athena-driver) #7407 allow to pass credentials

[trompa]

Check List

• Tests has been run in packages where changes made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
examples-angular-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-d3	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-dashboard	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-data-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-highcharts	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-material-ui	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-react-pivot-table	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am
examples-vue-query-builder	⬜️ Ignored (Inspect)	Visit Preview		Nov 23, 2023 11:33am

[trompa]

I've actually found that this change wont work if I want to pass a provider. It compares to undefined and will override it.
will push a change where it checks typeof, so promises are also evaluated correctly

[ovr]

I suggest simplifying this code by moving the original code for credentials:

credentials: accessKeyId && secretAccessKey
        ? { accessKeyId, secretAccessKey }
        : undefined,

before ...restConfig.

It will allow anyone to redeclare credentials by passing it via constructor

[ovr]

[ovr]

Thank you @trompa, for your contribution! 🍰

[M1ke]

This appears to cause a regression for services using instance metadata and not passing credentials in. We have a working cube install in production on v0.33 that when upgraded to v0.34 returns:

Resolved credential object is not valid

Rolling back to v0.33 resolved this. Checking the diff I can't see exactly why this might be the case, unless ...restConfig is exposing some requirement for credentials that's overwriting the credentials key in the object.

[ovr]

@M1ke

This appears to cause a regression for services using instance metadata and not passing credentials in.

It doesn't change that behavior. credentials is defined in both versions (before/after). This PR allows to override default credentials. Do you pass undefined as credentials?

Thanks