Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clickhouse-driver): Correct parsing for DateTime64, fix #7537 #7538

Merged
merged 3 commits into from Dec 18, 2023

Conversation

ovr
Copy link
Member

@ovr ovr commented Dec 15, 2023

Hello!

Thanks

@ovr ovr requested review from a team as code owners December 15, 2023 16:44
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2023 4:42pm

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (75e201d) 48.06% compared to head (b039bdb) 48.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7538   +/-   ##
=======================================
  Coverage   48.06%   48.06%           
=======================================
  Files         154      154           
  Lines       20894    20894           
  Branches     5370     5370           
=======================================
  Hits        10042    10042           
  Misses      10112    10112           
  Partials      740      740           
Flag Coverage Δ
cube-backend 48.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the fix/clickhouse-driver-datetime64-parsing branch from 48dd688 to 43506c1 Compare December 18, 2023 14:53
@ovr ovr force-pushed the fix/clickhouse-driver-datetime64-parsing branch from 41263cf to 8b13c71 Compare December 18, 2023 15:27
@ovr ovr merged commit 401e9e1 into master Dec 18, 2023
44 of 45 checks passed
@ovr ovr deleted the fix/clickhouse-driver-datetime64-parsing branch December 18, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant