Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): In subquery support #7851

Merged
merged 3 commits into from Feb 28, 2024
Merged

feat(cubesql): In subquery support #7851

merged 3 commits into from Feb 28, 2024

Conversation

waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 35.41667% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 67.96%. Comparing base (7b797bf) to head (bdd01db).
Report is 11 commits behind head on master.

Files Patch % Lines
.../cubesql/src/compile/engine/df/optimizers/utils.rs 0.00% 15 Missing ⚠️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 50.00% 14 Missing ⚠️
rust/cubesql/cubesql/src/sql/statement.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7851       +/-   ##
===========================================
- Coverage   79.16%   67.96%   -11.20%     
===========================================
  Files         193      347      +154     
  Lines       37545    58661    +21116     
  Branches        0     5403     +5403     
===========================================
+ Hits        29721    39871    +10150     
- Misses       7824    18041    +10217     
- Partials        0      749      +749     
Flag Coverage Δ
cube-backend 47.93% <ø> (?)
cubesql 79.13% <35.41%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2024 0:21am

@waralexrom waralexrom requested a review from a team as a code owner February 28, 2024 12:21
@waralexrom waralexrom merged commit 8e2a3ec into master Feb 28, 2024
55 checks passed
@waralexrom waralexrom deleted the cubesql/in-subquery branch February 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants