Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Incorrect CASE WHEN generated during ungrouped filtered… #7859

Merged
merged 1 commit into from Mar 1, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Mar 1, 2024

… count

Fixes #7858

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner March 1, 2024 07:25
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-react-d3 ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-react-dashboard ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-react-data-table ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-react-highcharts ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-react-material-ui ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am
examples-vue-query-builder ⬜️ Ignored (Inspect) Mar 1, 2024 7:25am

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.95%. Comparing base (16e2ee0) to head (8d054af).
Report is 1 commits behind head on master.

Files Patch % Lines
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 0.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7859       +/-   ##
===========================================
- Coverage   68.01%   47.95%   -20.07%     
===========================================
  Files         347      154      -193     
  Lines       58730    20994    -37736     
  Branches     5403     5404        +1     
===========================================
- Hits        39944    10067    -29877     
+ Misses      18037    10177     -7860     
- Partials      749      750        +1     
Flag Coverage Δ
cube-backend 47.95% <0.00%> (-0.01%) ⬇️
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit f970937 into master Mar 1, 2024
42 checks passed
@paveltiunov paveltiunov deleted the incorrect-filtered-distinct branch March 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect CASE WHEN generated during ungrouped filtered count
1 participant