Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Remove excessive limit on inner wrapped queries #7864

Merged
merged 1 commit into from Mar 2, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Mar 2, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Fixes #7858

Copy link

vercel bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2024 1:37am
examples-react-d3 ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am
examples-react-dashboard ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Mar 2, 2024 1:37am
examples-react-highcharts ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am
examples-react-material-ui ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am
examples-react-pivot-table ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am
examples-vue-query-builder ⬜️ Ignored (Inspect) Mar 2, 2024 1:37am

@paveltiunov paveltiunov requested review from a team as code owners March 2, 2024 01:36
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 68.03%. Comparing base (00a6ec0) to head (64e6c9a).

Files Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 72.00% 7 Missing ⚠️
packages/cubejs-api-gateway/src/gateway.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7864       +/-   ##
===========================================
+ Coverage   47.95%   68.03%   +20.08%     
===========================================
  Files         154      347      +193     
  Lines       20994    58771    +37777     
  Branches     5404     5404               
===========================================
+ Hits        10067    39983    +29916     
- Misses      10177    18038     +7861     
  Partials      750      750               
Flag Coverage Δ
cube-backend 47.95% <0.00%> (ø)
cubesql 79.19% <83.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit b97268f into master Mar 2, 2024
61 checks passed
@paveltiunov paveltiunov deleted the fix-ungrouped-queries-limit branch March 2, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect CASE WHEN generated during ungrouped filtered count
1 participant