Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: primary and foreign keys driver queries #8115

Merged
merged 12 commits into from Apr 23, 2024
Merged

feat: primary and foreign keys driver queries #8115

merged 12 commits into from Apr 23, 2024

Conversation

vasilev-alex
Copy link
Member

No description provided.

@vasilev-alex vasilev-alex requested a review from ovr April 10, 2024 16:11
@vasilev-alex vasilev-alex requested a review from a team as a code owner April 10, 2024 16:11
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 10:48am

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 47.82%. Comparing base (815be2f) to head (1197472).
Report is 71 commits behind head on master.

❗ Current head 1197472 differs from pull request most recent head 3cbc0f9. Consider uploading reports for the commit 3cbc0f9 to get more accurate results

Files Patch % Lines
packages/cubejs-base-driver/src/BaseDriver.ts 0.00% 32 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8115      +/-   ##
==========================================
- Coverage   47.90%   47.82%   -0.09%     
==========================================
  Files         154      154              
  Lines       21034    21069      +35     
  Branches     5422     5427       +5     
==========================================
- Hits        10077    10076       -1     
- Misses      10203    10233      +30     
- Partials      754      760       +6     
Flag Coverage Δ
cube-backend 47.82% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vasilev-alex vasilev-alex requested a review from a team as a code owner April 16, 2024 13:25
@vasilev-alex vasilev-alex requested a review from a team as a code owner April 19, 2024 08:30
@vasilev-alex vasilev-alex changed the title feat: primary keys driver query feat: primary and foreign keys driver queries Apr 19, 2024
@vasilev-alex vasilev-alex changed the title feat: primary and foreign keys driver queries feat(schema-compiler): primary and foreign keys driver queries Apr 19, 2024
@vasilev-alex vasilev-alex changed the title feat(schema-compiler): primary and foreign keys driver queries feat: primary and foreign keys driver queries Apr 19, 2024
@vasilev-alex vasilev-alex merged commit 35bb1d4 into master Apr 23, 2024
50 checks passed
@vasilev-alex vasilev-alex deleted the pk-query branch April 23, 2024 11:40
JichaoS pushed a commit to luabase/cube that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants