Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): In subquery rewrite #8162

Merged
merged 18 commits into from Apr 24, 2024
Merged

Conversation

waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 4:01pm

Copy link
Member

@ovr ovr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 95.53073% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 74.33%. Comparing base (815be2f) to head (c380933).
Report is 73 commits behind head on master.

❗ Current head c380933 differs from pull request most recent head 78d928a. Consider uploading reports for the commit 78d928a to get more accurate results

Files Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 90.80% 8 Missing ⚠️
...sql/src/compile/rewrite/rules/wrapper/aggregate.rs 96.36% 2 Missing ⚠️
...ubesql/src/compile/rewrite/rules/wrapper/filter.rs 96.36% 2 Missing ⚠️
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 0.00% 1 Missing ⚠️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 96.66% 1 Missing ⚠️
...ql/src/compile/rewrite/rules/wrapper/projection.rs 98.52% 1 Missing ⚠️
...esql/src/compile/rewrite/rules/wrapper/subquery.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #8162       +/-   ##
===========================================
+ Coverage   47.90%   74.33%   +26.43%     
===========================================
  Files         154      201       +47     
  Lines       21034    27260     +6226     
  Branches     5422        0     -5422     
===========================================
+ Hits        10077    20265    +10188     
+ Misses      10203     6995     -3208     
+ Partials      754        0      -754     
Flag Coverage Δ
cube-backend ?
cubesql 74.33% <95.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waralexrom waralexrom merged commit d17c2a7 into master Apr 24, 2024
64 checks passed
@waralexrom waralexrom deleted the cubesql/in-subquery-rewrite branch April 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants