feat(firebolt): Switch to the new auth method #8182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
github-actions
bot
added
the
pr:community
|
Credentials for testing you already poses should work in legacy mode, however a new set has been setup so service account auth can be tested. Let me know how can I send you the new credentials so you can update them in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Firebolt has a new version that requires service account authentication in order to connect programmatically. Reflecting these changes in code as well as docs.
Username/password is now legacy, working only for customers on the old version of Firebolt, who are gradually being migrated.
firebolt-sdkhandles connection to the right version, but needs the correct credentials wrapper, which is determined based on the presence of @ symbol in the email (service account id is alpha-numeric only).CUBEJS_DB_USER/PASS environment variables are used to be backwards-compatible with the connections setup on the old versions of the connector.
CUBEJS_FIREBOLT_ACCOUNT is required for the new authentication to succeed.