fix(server-core): Headers sent multiple times from dev-server handlers crashes it #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aggregation dev-server handle Without this control would fall through, and try to send response twice
… more robust to different response states
github-actions
bot
added
the
pr:community
MazterQyou
approved these changes
Jul 15, 2024
paveltiunov
approved these changes
Jul 16, 2024
paveltiunov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Description of Changes Made (if issue reference is not provided)
Due to forgotten return, one of request handlers tries to send response twice, leading to rejection, which gets caught, but error handler tries to send response one more time, throwing another exception, and crashing process with unhandled rejection.