Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1.0 Language issue #1310

Closed
Dirty-Butter opened this issue Oct 25, 2016 · 15 comments
Closed

6.1.0 Language issue #1310

Dirty-Butter opened this issue Oct 25, 2016 · 15 comments
Assignees
Labels
Milestone

Comments

@Dirty-Butter
Copy link

I've upgraded to 6.1.0 on a test site and on dirtybutterestates. Everything seems to be working correctly
EXCEPT neither site is paying any attention to any changes to the Language files that I have previously made. I'm getting stock wording, even though I have the edited terms clearly showing in Admin>Languages. I've cleared language cache and browser and even rebooted the computer.

SEE INFO AND DETAILS wording on product button.

estateslanguage

estatesinfo

@Dirty-Butter
Copy link
Author

I tested this on the CC Demo store, and it accepted new changes to the Language file from the Filemanager Language edits, so this must be some merging error I've made in both sites.

@Dirty-Butter
Copy link
Author

It was not a merging error after all, but the change I had made to redis cache in global.includes.
https://forums.cubecart.com/topic/51791-need-help-language-file-edits-not-being-used/?do=findComment&comment=221154

I'll contact Ian about this.

@abrookbanks
Copy link
Member

abrookbanks commented Oct 27, 2016

This might relate to this: #1313

Can you download master here: https://github.com/cubecart/v6/archive/master.zip and then replace the following files in the folder below:

classes/cache/*

@Dirty-Butter
Copy link
Author

I replaced the class cache files as directed, changed back to redis in the test store, empied all cache in maintenance - but language changes were still ignored. But Ian said he had not tested the redis he has on the server with any CC installs and the includes file needed parameters anyway.

@abrookbanks
Copy link
Member

abrookbanks commented Oct 27, 2016

OK. If you use the file cache does that work?

In includes/global.inc.php
$glob['cache'] = 'file';

@Dirty-Butter
Copy link
Author

I still have your reverted versions of classes/cache. I put $glob back to memcached, cleared all cache, and language edits immediately showed again.

@abrookbanks
Copy link
Member

abrookbanks commented Oct 27, 2016

Looks like a Redis cache class bug then. Thanks Rosemary this is a big help.

@Dirty-Butter
Copy link
Author

Dirty-Butter commented Oct 27, 2016

glad I could be of help Should I revert the cache files to stock 6.1.0?

@abrookbanks
Copy link
Member

Sorry for any inconvenience caused.

@Dirty-Butter
Copy link
Author

I always learn something - no need to apologize at all. Should I revert the cache files to stock 6.1.0?

@abrookbanks
Copy link
Member

The ones you are on are fine but it may be good to about the redis one for now.

@Dirty-Butter
Copy link
Author

Reverting redis file to stock 6.1.0.

@abrookbanks
Copy link
Member

The master build right now is better than 6.1.0 release.

@Dirty-Butter
Copy link
Author

OK - misunderstood

@abrookbanks abrookbanks added this to the 6.1.1 milestone Oct 28, 2016
@abrookbanks abrookbanks self-assigned this Oct 28, 2016
@abrookbanks
Copy link
Member

This was caused by an invalid check on the exists method of the redis cache class. Fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants