New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smarty's New Code Not Compatible with Something #1990
Comments
I'm not a windows man at all. Is there a way to debug 'Unhandled Win32 Exception'? Please remember that strictly speaking Windows is not a supported platform. Can you install a different version of PHP? Just because MS Server 2003 doesn't support PHP 5.5 and above can't you configure it manually? https://windows.php.net/download#php-7.2 ... as I said I have almost zero PHP, IIS, Windows experience. |
I have eliminated the HTMLMinify filter as the cause of the problem. That leaves the new {combine} function. |
I wonder if there is a specific function in it that the server doesn't like. For example Solaris will not work with a glob brace flag. I expect the sever is taking exception to something in that file. |
I have a feeling in my bones it's this. |
I have narrowed the problem to be triggered by sending a large file through CSSmin.php. See: PCRE limitations being set too high, allowing for an Apache stack overflow and absolutely no errors logged. |
Made the change to give Apache 8MB stack size (default for Windows 1MB, Linux 8MB). The combined CSS file created successfully. I think JSmin would not have been a problem, as I do not find any sort of PCRE functions being used there. |
OK so it sounds like we can close this one and keep it in mind for Windows users. PHP 5.4 is past its end of life now anyway so its seems silly to adapt CubeCart around this. |
Technically, the problem was not with PHP. The specific environment of Apache 2.2 (maybe any version of Apache) on a 32-bit Windows (maybe any bitsize) box using a specific function (apparently with known limitations) on a sufficiently large file. Overflowing the stack. Which means, with a sufficiently large file, this will occur on any kit. |
https://stackoverflow.com/questions/5058845/how-do-i-increase-the-stack-size-for-apache-running-under-windows-7 |
FYI:
CC620:
See: https://forums.cubecart.com/topic/53926-cc620-crashes-php/
I replaced the Smarty folder and the Foundation skin folder (and commented relevant lines in the controller) with CC6115 versions and the problem did not manifest.
The text was updated successfully, but these errors were encountered: