Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKEDITOR ShowProtected Plugin Malforms FullPage HTML #2285

Closed
bhsmither opened this issue Apr 17, 2019 · 3 comments
Closed

CKEDITOR ShowProtected Plugin Malforms FullPage HTML #2285

bhsmither opened this issue Apr 17, 2019 · 3 comments

Comments

@bhsmither
Copy link
Contributor

bhsmither commented Apr 17, 2019

In /ckeditor/config.js:

Problem exists:
	config.protectedSource.push(/{\S*?.*?\S}/g);
	config.extraPlugins = 'showprotected';

Problem exists, content not protected, with a false hit:
/*	config.protectedSource.push(/{\S*?.*?\S}/g); */
	config.extraPlugins = 'showprotected';

Problem does not exist, but no protected content shown:
	config.protectedSource.push(/{\S*?.*?\S}/g);
/*	config.extraPlugins = 'showprotected'; */

Problem does not exist, but content not protected:
/*	config.protectedSource.push(/{\S*?.*?\S}/g); */
/*	config.extraPlugins = 'showprotected'; */

This experiment shows that the Show Protected plugin is causing FullPage HTML structure to become malformed.

@bhsmither
Copy link
Contributor Author

I installed CKEDITOR 4.11.4 and the latest version of the of the Show Protected plugin.

It still misbehaves, although the resulting display is just a bit different.

@bhsmither
Copy link
Contributor Author

bhsmither commented Apr 18, 2019

That's because the plugin added:

display:block;

to the styling of the blue "code" icon.

I changed it to inline-block and it looks good (still misbehaves).

(Note: it's difficult/impossible to get Firefox to force reload an iframe page's resources. Argh!)

@abrookbanks
Copy link
Member

Maybe we need to retire FCKEditor and use a different solution. It's never worked for us with macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants