Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All in One Shipping Tweak #2414

Closed
bhsmither opened this issue Oct 31, 2019 · 4 comments
Closed

All in One Shipping Tweak #2414

bhsmither opened this issue Oct 31, 2019 · 4 comments
Assignees

Comments

@bhsmither
Copy link
Contributor

Request in the file /admin/index.inc.php (and all other files in the module), to replace any sensible occurrence of All_In_One_Shipping to $_GET['module'].

This solves the edge case where the module has been renamed (for example, to AIOS_1015).

(I have made this replacement to many other modules.)

@abrookbanks
Copy link
Member

There seems to be only one occurance.

$GLOBALS['smarty']->append('EXTRA_JS', 'modules/shipping/All_In_One_Shipping/js/all_in_one_shipping.min.js');

@bhsmither
Copy link
Contributor Author

In shipping_rates.tpl, lines 59 and 65, replace with {$MODULE.folder}.

In index.tpl, line 8 and 155, replace id="All_In_One_Shipping" with id="{$GENERAL_TAB_ID}".

Same file, line 156, replace with {$MODULE.folder}.

In all_in_one_shipping.min.js, line 70, replace with something like:

$("div#page_content form div:first-child").attr("id")

@abrookbanks
Copy link
Member

Thanks. I'll get this done before release next week...

@abrookbanks
Copy link
Member

Implemented in AllInOneShipping-1.0.16.zip. All seems to be working well. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants