New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new ReCaptcha doesn't work on some skins #674

Closed
Noodleyman opened this Issue Jul 8, 2015 · 31 comments

Comments

Projects
None yet
4 participants
@Noodleyman

Noodleyman commented Jul 8, 2015

I got caught out by this today, I enabled the "New ReCAPTCHA" settings, it works OK in foundation skin, but in Kurouto the recaptcha doesn't load.

This in turn causes the challenge to always fail.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Jul 17, 2015

Thats right. I'm not going to develop the v5 skins to have this feature I'm afraid. :(

@Noodleyman

This comment has been minimized.

Noodleyman commented Jul 17, 2015

I think there is room for an enhancement here.

Observation:
You have the skins listed in the market place as supported in V6, but this feature within those skins doesn't work with V6.

Suggestion:
If using a known V5 skin, remove the ability to select the "New Recapture" from the settings page because it will prevent frustrations trying to get it to work and make for a better customer experience.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Jul 17, 2015

Thats a good idea.

@Noodleyman

This comment has been minimized.

Noodleyman commented Jul 17, 2015

Can the ticket be reopened and labelled as an enhancement for a future release? :)

@Noodleyman

This comment has been minimized.

Noodleyman commented Jul 17, 2015

Thank you Al 👍

@Noodleyman Noodleyman closed this Sep 15, 2016

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Sep 15, 2016

I'd like to reopen this as Kurouto etc should support the new Recaptcha. Clients on the support helpdesk request this a lot.

@abrookbanks abrookbanks reopened this Sep 15, 2016

@abrookbanks abrookbanks self-assigned this May 4, 2017

@abrookbanks abrookbanks added the bug label May 4, 2017

@abrookbanks abrookbanks added this to the 6.1.7 milestone May 4, 2017

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented May 4, 2017

Thanks for this. Since 6.1.7 the settings will tell the user which options are available to them which will save confusion.

@abrookbanks abrookbanks closed this May 4, 2017

@demand73

This comment has been minimized.

demand73 commented Feb 28, 2018

Is there any work being done with making Kurouto V6 compatible? or atleast working with the new recapcha? google will inactivate recapcha V1 2018-03-31. I like the Kurouto skin and there is still many stores using it cause Foundation is so ugly =) and the #1883 solution with disable reCaptcha V1 will render Kurouto webshops unusable.

@abrookbanks abrookbanks reopened this Feb 28, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Feb 28, 2018

Reopened to integrate reCaptcha V2.

@abrookbanks abrookbanks removed this from the 6.1.7 milestone Feb 28, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Feb 28, 2018

This will be completed by Friday 2nd March.

Notes below as a reference to assist me with upgrades..
The following code will also be added so the default homepage document images display neatly.

.bxslider img {
    width: 100%;
    height: auto;
}

Following line required in main.inc.php template:

{include file='templates/content.recaptcha.head.php'}
@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@Noodleyman

This comment has been minimized.

Noodleyman commented Mar 1, 2018

You've been busy :)

I was curious if there is any documented steps that can be given to people who may be running custom versions of the themes you've updated and want to apply it manually?

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

I've done this many times for customers on the Technical Support & Management plan it's pretty much second nature.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

Now for the WebCity skins.. tea break first..

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 1, 2018

All officially maintained skins have now been updated... right who's round is it? Hehe.

@abrookbanks abrookbanks closed this Mar 1, 2018

@demand73

This comment has been minimized.

demand73 commented Mar 1, 2018

Super thanks, it works like a charm.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 2, 2018

Great! It's been on my radar a while. The EoL date was the required kick up the backside. Have a nice day.

@bhsmither

This comment has been minimized.

Contributor

bhsmither commented Mar 21, 2018

(Haven't actually verified this yet...)
I see that Kurouto/1.0.3 has had what appears to be a recent version of Foundation's content.recaptcha.php.

Is this intentional?

I just wonder what I would be missing since SVG and Foundation classes are not part of any other CC5 skin.

@abrookbanks

This comment has been minimized.

Member

abrookbanks commented Mar 21, 2018

Yes it's intentional. The SVG images are only used with the phased out version. reCaptcha V2 will work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment