New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(port): support multiple datanode/metanode instances using dif… #3016
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
691481a
to
a049fef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
+ Coverage 41.95% 41.99% +0.03%
==========================================
Files 577 577
Lines 119055 119381 +326
==========================================
+ Hits 49946 50129 +183
- Misses 64831 64974 +143
Partials 4278 4278 ☔ View full report in Codecov by Sentry. |
It's a really good and big job, and maybe you should consider the process of upgrading an old cluster because the default values for |
de2b715
to
717c946
Compare
I have made some attempts to resolve the compatibility issues when upgrading the old version.I have finished the dataNode part, but I think it has something wrong and there is still a state inconsistency problem when synchronizing raft information.The scenario I tested was to restart all the Masters first, and then restart the dataNodes one by one. |
5b9ddab
to
19ad51b
Compare
The problem I encounter now is that after dataNodes are restarted one by one, although the META information in the locally stored dp file can be updated to the new version with port information, the META information may not be correctly changed when other member changes such as del-replica are performed. |
I found that in the branch <develop-hybridcloud-lifecycle>, the branch also changes the structure of dataNode with adding |
19ad51b
to
1617f49
Compare
…ent port on a single node Signed-off-by: CNyuchenZhang <yuchen.zhang6688@gmail.com>
5873b0e
to
b93f327
Compare
I think the problem mentioned doesn't exist anymore, but I'm not sure if there are other problems because I haven't fully understood the mechanism here. |
b93f327
to
57c835c
Compare
Signed-off-by: CNyuchenZhang <yuchen.zhang6688@gmail.com>
57c835c
to
ce18fef
Compare
|
…ferent port on a single node
What this PR does / why we need it:
Support multiple datanode/metanode instances using different port on a single node.In the previous version, every datanode or metanode in the same raft group is required to be configured with the same raftHeartBeatPort and replicaPort because each node splices ports of peers through its own port.
Which issue this PR fixes:
fixes #3004
Special notes for your reviewer:
Release note: