Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add luacheck in CI #26

Closed
madmaxoft opened this issue Oct 31, 2016 · 4 comments
Closed

Add luacheck in CI #26

madmaxoft opened this issue Oct 31, 2016 · 4 comments
Assignees

Comments

@madmaxoft
Copy link
Member

Luacheck should be added as another test in the CI.

@Seadragon91
Copy link
Contributor

This are my current changes in CuberitePluginChecker.
I added the file .lauchecrc, install and run luacheck. The file will be added to the plugin directory if the plugin doesn't contain it.

@Seadragon91
Copy link
Contributor

Seadragon91 commented Nov 23, 2016

Current result from circleci.

Edit: The q flag filters out files from output, where luacheck doesn't detect any problems.

Seadragon91 referenced this issue in Seadragon91/CuberitePluginChecker Nov 23, 2016
@madmaxoft
Copy link
Member Author

This is not what I had in mind when creating this issue. I wanted LuaCheck to actually check this repo, not another plugin. Adding LuaCheck to other plugins is a matter of those plugins, not CuberitePluginChecker.

Also, the CI script is malformed now - consider that all actions listed in the test/override section can be run in parallel next to each other. All the setup needed for the test needs to be done on a single line.

@Seadragon91
Copy link
Contributor

Ah okay sorry, will create a pull request that adds luacheck and we can discuss there about correcting problems in CuberitePluginChecker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants