Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various issues found by static analyzer #45

Open
v1993 opened this issue Sep 13, 2019 · 1 comment
Open

Various issues found by static analyzer #45

v1993 opened this issue Sep 13, 2019 · 1 comment
Assignees
@qwertychouskie @v1993
Labels
Good first issue Good for newcomers Priority: P2 High priority T: Bug Something isn't working

Comments

@v1993
Copy link
Member

v1993 commented Sep 13, 2019

I've recently added cubosphere to https://lgtm.com and it have discovered a lot of issues, from medium to serious importance.

You can check full list of alerts at https://lgtm.com/projects/g/cubosphere/cubosphere-code.

I'm not working on cubosphere, but those issues are pretty serious and should be fixed first before continuing. Most of them are pretty trivial tho, so feel free to take on them in free time.
@v1993 v1993 added T: Bug Something isn't working Priority: P2 High priority labels Sep 13, 2019
@v1993 v1993 changed the title Various issues (including very serious ones) Various issues (including pretty serious ones) Sep 13, 2019
@v1993 v1993 self-assigned this Sep 13, 2019
This was referenced Sep 13, 2019
Merged
Merged
@v1993 v1993 added the Good first issue Good for newcomers label Sep 13, 2019
@v1993 v1993 pinned this issue Sep 13, 2019
@v1993
Copy link
Member Author

v1993 commented Sep 13, 2019

Now when errors and warnings are fixed, this is less critical. However, remaining problems still need attention.

I'll create branch lgtm-problems-recommendations-1. Push your work on this issue there (I'll probably go for few more fixes too).

@v1993 v1993 changed the title Various issues (including pretty serious ones) Various issues found by static analyzer Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwertychouskie qwertychouskie

@v1993 v1993

Labels
Good first issue Good for newcomers Priority: P2 High priority T: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qwertychouskie @v1993