aruba init --test-framework cucumber adds aruba to Gemfile incorrectly but reports it as successful.

[dyspop]

Summary

Initializing cucumber-ruby incorrectly appends the Gemfile and returns to stdout an incorrect success status.

Expected Behavior

source 'https://rubygems.org'

# Specify your gem's dependencies in wisu.gemspec
gemspec

group :test do
  gem 'cucumber'
  gem 'aruba'
end

group :development, :test do
  gem 'rspec-rails', '~> 3.5'
  gem 'aruba', '~> 0.14.2'
end

When I run $aruba init --test-framework cucumber it should either append correctly or in the very least it should not display a success response for the append.

Current Behavior

When I run $aruba init --test-framework cucumber at root it correctly creates features/support/aruba.rb and responds with a successful append Gemfile response, but inspection of the Gemfile shows that it appended it incorrectly:

$aruba init --test-framework cucumber
      create  features/support/aruba.rb
      append  Gemfile

Gemfile:

source 'https://rubygems.org'

# Specify your gem's dependencies in wisu.gemspec
gemspec

group :test do
  gem 'cucumber'
  gem 'aruba'
end

group :development, :test do
  gem 'rspec-rails', '~> 3.5'
endgem 'aruba', '~> 0.14.2'

Steps to Reproduce (for bugs)

above

Context & Motivation

I simply manually rewrote this. Since it's init it's not a huge deal but I can imagine it tripping someone up.

Your Environment

• Version used: aruba (0.14.2)
• Operating System and version: OS X El Capitan 10.11.6
• Link to your project: Currently in a private repository

[dyspop]

This is probably because I already had gem 'cucumber' in the wrong spot now that I look at it again. Do what you want with this.

[maxmeyer]

Mmh. Can you check if your file contains a "\n" at the very end of the file?

[dyspop]

Hhm. I didn't commit it in that state and moved on. Sorry!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[stale]

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

[mvz]

I can reproduce this behavior using a Gemfile with no "\n" at the end.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[xtrasimplicity]

Bump.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[luke-hill]

This feels like a reproduction of the bug I raised a bit ago

#662

I'll close this as a duplicate in favour of the other one (Which is a more in-depth detailed look)

[mvz]

I think the problem here is similar, but still different since it occurs outside of cucumber scenarios. #570 seems to fix it.

[luke-hill]

I disagree, as that adds a newline only in one circumstance, whereas the generic fix is to fix up the append to cuke. But fair point, having the issues as separate I guess is valid.