Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "try" into a dedicated project #106

Closed
aurelien-reeves opened this issue Apr 15, 2022 · 5 comments
Closed

Move "try" into a dedicated project #106

aurelien-reeves opened this issue Apr 15, 2022 · 5 comments

Comments

@aurelien-reeves
Copy link
Contributor

🤔 What's the problem you've observed?

The "try" as part of cucumber-expression javascript implementation oversize it and add a lot of dependency to cucumber-expression itself. It could live on its own, being inside its own repo, or within a dedicated folder within this repo

Refs. #104 (comment)

✨ Do you have a proposal for making it better?

I would put it its in own repo actually, thus it would not interfere with cucumber-expression at all


This text was originally generated from a template, then edited by hand. You can modify the template here.

@aslakhellesoy
Copy link
Contributor

I agree! We could move it to cucumber/try-cucumber-expressions

@aslakhellesoy
Copy link
Contributor

The "try" as part of cucumber-expression javascript implementation oversize it and add a lot of dependency to cucumber-expression itself.

None of the code from the try directory is included in the published npm module. Furthermore, all of the dependencies of try are devDependencies.

Nevertheless, I agree we should move it out.

@mpkorstanje
Copy link
Contributor

Yes, because stuff like #112 keeps generating notifications.

@aslakhellesoy
Copy link
Contributor

Done!

@mpkorstanje
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants