This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed previously with Aslak, I suggest we rename the cucumber-html namespace (i.e. the entry-point variable name) to
CucumberHTML
(fromCucumber
).The reason is simple: it will practically clash with Cucumber.js's own
Cucumber
function.By practically I mean that it should not be a real problem from a technical perspective. Thanks to the CommonJS modules the two identically-named variables won't live in the same scopes. Cucumber.js is always
require
'd (even in the browser, through browserify); therefore it won't ever be in the scope of cucumber-html'sCucumber
.However, the natural way of referring to cucumber.js's main object function is something like:
This of course won't play well with cucumber-html also declared as
Cucumber
.Plus, the name
Cucumber
is simply a bit too generic for the content of this project, IMHO.Hit me with better name suggestions if you can!