-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test browser apps in-process with Electron #1799
Comments
Two thoughts:
|
👍
I think that was the idea, yes. Having dependencies related to that feature as peer dependencies. |
Peer dependencies I’m not sure about - since npm 7 by default it throws if peer dependencies are missing. There’s no way of specifying “optional peers” unfortunately. But we could do some good messaging to the user at runtime if the plugin is missing. |
Keep in mind that Cucumber-Electron currently uses I suggest:
|
@aslakhellesoy could you still use |
@mattwynne I think you mentioned there was an initiative around this internally - do you still think it should be a part of Cucumber itself? |
Yeah, I do. I'm not sure what will happen internally but for me this functionality would be a great addition to cucumber-js, provided we can architect it in a way that doesn't bloat / complicate the codebase. |
Is your feature request related to a problem? Please describe.
The https://cucumber/cucumber-electron project has prototyped and proven the concept of integration cucumber-js with electron to run lightning-fast acceptance tests against browser apps. It's very cool.
A discussion about finding a better name for that project to help it find a bigger audience ended in the conclusion that it would be better to fold that behaviour into the main cucumber-js project as an additional capability.
Describe the solution you'd like
This is to be decided. Perhaps an
--electron
switch that spins up the Electron wrapper?The text was updated successfully, but these errors were encountered: