Fixed bug where -getSnippet in clj.clj received only the step parameter.

cucumber.runtime.UndefinedStepsTracker actually calls the Backend instances with 2 parameters--Step and FunctionNameGenerator--but Clojure's Backend implementation only accepts one. Instead of testing generation of Clojure Snippet with a test-only ClojureSnippet instance, ClojureSnippetTest now tests the real implementation in clj.clj.
cucumber · Dec 19, 2013 · 5e3d2fd · 5e3d2fd
1 parent 77a93d1
commit 5e3d2fd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 50 deletions.
diff --git a/clojure/src/main/clj/cucumber/runtime/clj.clj b/clojure/src/main/clj/cucumber/runtime/clj.clj
@@ -57,8 +57,8 @@
 
 (defn- -disposeWorld [cljb])
 
-(defn- -getSnippet [cljb step]
-  (.getSnippet snippet-generator step))
+(defn- -getSnippet [cljb step _]
+  (.getSnippet snippet-generator step nil))
 
 (defn- -setUnreportedStepExecutor [cljb executor]
   "executor")

diff --git a/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java b/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippet.java
diff --git a/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippetTest.java b/clojure/src/test/java/cucumber/runtime/clojure/ClojureSnippetTest.java
@@ -1,6 +1,6 @@
 package cucumber.runtime.clojure;
 
-import cucumber.runtime.snippets.SnippetGenerator;
+import cucumber.runtime.clj.Backend;
 import gherkin.formatter.model.Comment;
 import gherkin.formatter.model.DataTableRow;
 import gherkin.formatter.model.Step;
@@ -18,7 +18,7 @@ public class ClojureSnippetTest {
     @Test
     public void generatesPlainSnippet() {
         Step step = new Step(NO_COMMENTS, "Given ", "I have 4 cukes in my \"big\" belly", 0, null, null);
-        String snippet = new SnippetGenerator(new ClojureSnippet()).getSnippet(step, null);
+        String snippet = (new Backend(null)).getSnippet(step, null);
         String expected = "" +
                 "(Given #\"^I have (\\d+) cukes in my \\\"([^\\\"]*)\\\" belly$\" [arg1 arg2]\n" +
                 "  (comment  Write code here that turns the phrase above into concrete actions  )\n" +
@@ -30,7 +30,7 @@ public void generatesPlainSnippet() {
     public void generatesSnippetWithDataTable() {
         List<DataTableRow> dataTable = asList(new DataTableRow(NO_COMMENTS, asList("col1"), 1));
         Step step = new Step(NO_COMMENTS, "Given ", "I have:", 0, dataTable, null);
-        String snippet = new SnippetGenerator(new ClojureSnippet()).getSnippet(step, null);
+        String snippet = (new Backend(null)).getSnippet(step, null);
         String expected = "" +
                 "(Given #\"^I have:$\" [arg1]\n" +
                 "  (comment  Write code here that turns the phrase above into concrete actions  )\n" +