Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java11 support - Feature Request #1557

Closed
rpjesivac opened this issue Feb 12, 2019 · 9 comments
Closed

Java11 support - Feature Request #1557

rpjesivac opened this issue Feb 12, 2019 · 9 comments
Labels
⚡ enhancement Request for new functionality
Milestone

Comments

@rpjesivac
Copy link

Summary

Java is now coming with more frequent releases (we’ll be getting Java updates twice a year and a LTS version every three years) and as much as it is not practical to support every single release I believe there should be a Cucumber support for LTS releases.

Currently Cucumber supports Java 8 and it does not support Java9, Java 10, and Java11.
However, Java 11 is the LTS release and I would expect that LTS releases are supports by Cucumber. (JBehave supports it but we don't want to make that switch)

When we can expecte Cucumber support for Java 11?

Thanks!

@mpkorstanje mpkorstanje added Java 11 ⚡ enhancement Request for new functionality labels Feb 13, 2019
@mpkorstanje
Copy link
Contributor

Cucumber can be build on OpenJDK 11 and the examples all pass. Could you be a bit more specific about the problems you encounter and/or the features you are missing?

When we can expect Cucumber support for Java 11?

Cucumber is an open source project and generally moves at the at the speed of it's contributors. As the contributors are primarily unpaid volunteers there are no time tables or schedules. Would you be willing and able to contribute?

@Blackwolf291
Copy link

the split package org.springframework.test.context prevents cucumber spring from being on a single module path with spring-test, this is one thing that would help if it were changed

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Feb 19, 2019

There is a lovely bit of technical debt attached to that. Please see: #1470 for a solution.

In short the split package exists to ensure parallel execution is possible with spring. It need not exist but fixing it does require a reimplementation of cucumber-spring.

@mpkorstanje mpkorstanje modified the milestones: 5.x.x, 5.0.0 Apr 15, 2019
@treaves
Copy link

treaves commented Apr 25, 2019

The documentation also still states only up to Java 8 is supported.

@mlvandijk
Copy link
Member

@treaves afaik that is still true

@treaves
Copy link

treaves commented Apr 26, 2019

The documentation likely needs to be updated. As @mpkorstanje refers to above, it seems to work. I got in running tests in two Dropwizard JDK 11 projects yesterday.

@mpkorstanje
Copy link
Contributor

I think the documentation needs a bit more nuance.

For some use cases (e.g. running tests) Cucumber can be used with Java 11 without any problems. However other use cases that require Cucumbers code to be modularized (e.g. frameworks that use Cucumber) are not yet supported.

@mpkorstanje
Copy link
Contributor

@Blackwolf291 @rpjesivac @treaves would you mind trying with the latest 5.0.0-SNAPSHOT and see how Java 9+ works for you?

https://cucumber.io/docs/installation/java/#snapshot-releases

@mpkorstanje
Copy link
Contributor

With all the split packages gone and all modules having an automatic module name I reckon we're done here. Next step will be module-info.java but it is not required for Java 9+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Development

No branches or pull requests

5 participants