Include SourceReferences in message output #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
2058-add-source-reference
branch
2 times, most recently
from
627df73
to
088ae40
Compare
mpkorstanje
force-pushed
the
2058-add-source-reference
branch
from
088ae40
to
e88b849
Compare
mpkorstanje
force-pushed
the
2058-add-source-reference
branch
2 times, most recently
from
c564dd1
to
20c09d9
Compare
Cucumber JVM can not reference files by URI. So it should use either java
methods or stack trace elements as a source reference instead.
For example:
```
{
"hook": {
"id": "a1839ec6-f75d-4029-9b75-4b8203d8b2e8",
"sourceReference": {
"javaMethod": {
"className": "io.cucumber.compatibility.attachments.Attachments",
"methodName": "before",
"methodParameterTypes": [
"io.cucumber.java.Scenario"
]
}
}
}
}
```
See: cucumber/common#1119
Fixes: #2058
mpkorstanje
force-pushed
the
2058-add-source-reference
branch
from
20c09d9
to
c45bd86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber JVM can not reference files by URI. So it should use either java
methods or stack trace elements as a source reference instead.
For example:
{ "hook": { "id": "a1839ec6-f75d-4029-9b75-4b8203d8b2e8", "sourceReference": { "javaMethod": { "className": "io.cucumber.compatibility.attachments.Attachments", "methodName": "before", "methodParameterTypes": [ "io.cucumber.java.Scenario" ] } } } }See: cucumber/common#1119
Fixes: #2058