Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ignoring of JRuby backtraces. #266

Merged
merged 2 commits into from Apr 21, 2012

Conversation

akiellor
Copy link
Contributor

@akiellor akiellor commented Apr 9, 2012

No description provided.

@akiellor
Copy link
Contributor Author

akiellor commented Apr 9, 2012

I had some failures while running features under jruby, but they looked like existing failures.

The backtrace.feature was test on jruby 1.6.5, 1.6.6 and 1.6.7.

@mattwynne
Copy link
Member

@aslakhellesoy which versions of jruby are we supposed to support? It doesn't seem to be running jruby under travis-ci at all.

@aslakhellesoy
Copy link
Contributor

I think we should try to support the current minor version - currently 1.6

@mattwynne
Copy link
Member

@akiellor I don't suppose you'd like to help us fix the other failing tests would you? We could open another ticket for that.

@akiellor
Copy link
Contributor Author

Just tidied up the feature (sorry about that). I'd be happy to have a look at the other features. Do you think it would be possible to get a build running in travis so I can see what it thinks is failing?

mattwynne added a commit that referenced this pull request Apr 20, 2012
I don't really know what I'm doing here! This link[1] says to
use jruby 1.8 or jruby 1.9 mode, so I've added both. I'm not sure
what actual version of JRuby those translate to.

[1] http://about.travis-ci.org/docs/user/languages/ruby/
@mattwynne
Copy link
Member

Okay I've added jruby to the travis config. Do you want to open a separate pull request for fixing the JRuby tests, and I'll merge this one in?

@mattwynne
Copy link
Member

Thanks for your contribution Andrew!

mattwynne added a commit that referenced this pull request Apr 21, 2012
Fix ignoring of JRuby backtraces.
@mattwynne mattwynne merged commit 7ca542c into cucumber:master Apr 21, 2012
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants