Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"bundle exec rake cov" get "failed" message at the end of the run #584

Closed
jasnow opened this issue Nov 5, 2013 · 6 comments
Closed

"bundle exec rake cov" get "failed" message at the end of the run #584

jasnow opened this issue Nov 5, 2013 · 6 comments

Comments

@jasnow
Copy link
Contributor

jasnow commented Nov 5, 2013

I ran bundle exec rake cov (as mentioned in CONTRIBUTING.md)
and the tests are ran but I get failed message afterwards.

@tooky
Copy link
Member

tooky commented Nov 5, 2013

I think there's a known problem with SimpleCov and RSpec's at_exit hook.

We want to move to using coveralls, there's an open ticket #582.

@jasnow
Copy link
Contributor Author

jasnow commented Nov 5, 2013

Then this just turns into a documentation bug:

  • CONTRIBUTING.md:40: To get code coverage results, run bundle exec rake cov

@jasnow
Copy link
Contributor Author

jasnow commented Nov 5, 2013

Is there a Github ticket for the above known problem? Found simplecov-ruby/simplecov#41 but it is closed.

@tooky
Copy link
Member

tooky commented Nov 6, 2013

OK so this was a problem with cucumber.

We were getting an error in the simplecov at_exit hook, due to a non utf-8 character.

I've prevented this problem with this commit: 9d9dd2f

@tooky tooky closed this as completed Nov 6, 2013
@jasnow
Copy link
Contributor Author

jasnow commented Nov 6, 2013

WOW - Thanks - https://travis-ci.org/cucumber/cucumber/builds/13597767 - All green.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants