New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write formatters against new API #839

Closed
mattwynne opened this Issue Apr 20, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@mattwynne
Member

mattwynne commented Apr 20, 2015

For 3.0 the https://github.com/cucumber/cucumber/blob/master/lib/cucumber/formatter/legacy_api/adapter.rb should be removed, and all formatters that ship with Cucumber should go through the new, test-case based API.

Altogether there are:

  • progress (#859)
  • pretty (#1305)
  • html (#1306)
  • json (#851)
  • json_pretty (is the same as json)
  • junit (#855)
  • stepdefs (#859)
  • usage (#859)
  • debug can be removed - only for help writing old-API formatters
  • rerun done in (83a0c75)

I think the progress formatter is the place to start, as there's a lot of shared code in all the console formatters. If you want to tackle one, please create a ticket and reference this ticket.

@mattwynne

This comment has been minimized.

Show comment
Hide comment
@mattwynne

mattwynne Sep 2, 2016

Member

Pretty re-write investment may be best placed into https://github.com/cucumber/cucumber-pretty-formatter

Member

mattwynne commented Sep 2, 2016

Pretty re-write investment may be best placed into https://github.com/cucumber/cucumber-pretty-formatter

@mattwynne

This comment has been minimized.

Show comment
Hide comment
@mattwynne

mattwynne Jun 30, 2017

Member

Charlie Rudolph has just dropped the pretty formatter from cucumber-js altogether, and just just pretty-printing failures.

As much fun as it is writing pretty formatters, I think we should give serious consideration to doing the same, and giving ourselves a clean slate for these.

Member

mattwynne commented Jun 30, 2017

Charlie Rudolph has just dropped the pretty formatter from cucumber-js altogether, and just just pretty-printing failures.

As much fun as it is writing pretty formatters, I think we should give serious consideration to doing the same, and giving ourselves a clean slate for these.

@brasmusson brasmusson referenced this issue Oct 29, 2017

Merged

Remove the legacy_api #1230

1 of 7 tasks complete
@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the Stale label Nov 8, 2017

@stale

This comment has been minimized.

Show comment
Hide comment
@stale

stale bot Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this Nov 15, 2017

@brasmusson brasmusson reopened this Jan 4, 2018

@stale stale bot removed the Stale label Jan 4, 2018

@brasmusson brasmusson referenced this issue Jul 9, 2018

Merged

Let the Pretty Formatter use events #1305

3 of 7 tasks complete

@brasmusson brasmusson closed this in #1230 Jul 16, 2018

@mattwynne

This comment has been minimized.

Show comment
Hide comment
@mattwynne

mattwynne Jul 17, 2018

Member

💖 🌈 hooray!

Member

mattwynne commented Jul 17, 2018

💖 🌈 hooray!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment