Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write formatters against new API #839

Closed
mattwynne opened this issue Apr 20, 2015 · 6 comments
Closed

Re-write formatters against new API #839

mattwynne opened this issue Apr 20, 2015 · 6 comments
Milestone

Comments

@mattwynne
Copy link
Member

@mattwynne mattwynne commented Apr 20, 2015

For 3.0 the https://github.com/cucumber/cucumber/blob/master/lib/cucumber/formatter/legacy_api/adapter.rb should be removed, and all formatters that ship with Cucumber should go through the new, test-case based API.

Altogether there are:

  • progress (#859)
  • pretty (#1305)
  • html (#1306)
  • json (#851)
  • json_pretty (is the same as json)
  • junit (#855)
  • stepdefs (#859)
  • usage (#859)
  • debug can be removed - only for help writing old-API formatters
  • rerun done in (83a0c75)

I think the progress formatter is the place to start, as there's a lot of shared code in all the console formatters. If you want to tackle one, please create a ticket and reference this ticket.

@mattwynne
Copy link
Member Author

@mattwynne mattwynne commented Sep 2, 2016

Pretty re-write investment may be best placed into https://github.com/cucumber/cucumber-pretty-formatter

Loading

@mattwynne
Copy link
Member Author

@mattwynne mattwynne commented Jun 30, 2017

Charlie Rudolph has just dropped the pretty formatter from cucumber-js altogether, and just just pretty-printing failures.

As much fun as it is writing pretty formatters, I think we should give serious consideration to doing the same, and giving ourselves a clean slate for these.

Loading

@brasmusson brasmusson mentioned this issue Oct 29, 2017
7 tasks
@stale
Copy link

@stale stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

Loading

@stale stale bot added the stale label Nov 8, 2017
@stale
Copy link

@stale stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

Loading

@mattwynne
Copy link
Member Author

@mattwynne mattwynne commented Jul 17, 2018

💖 🌈 hooray!

Loading

@lock
Copy link

@lock lock bot commented Jul 17, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Loading

@lock lock bot locked as resolved and limited conversation to collaborators Jul 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants