Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support VS Code CLI as an alternative to ANSICON. #100

Closed
seraku24 opened this issue Dec 24, 2016 · 2 comments
Closed

Support VS Code CLI as an alternative to ANSICON. #100

seraku24 opened this issue Dec 24, 2016 · 2 comments

Comments

@seraku24
Copy link

seraku24 commented Dec 24, 2016

Summary

VS Code directly supports ANSI control sequences. However, cucumber only looks for the presence of ANSICON, which means no color output for VS Code users.

Possible Solution

Within ansicolor.rb, simply add an additional check for the presence of VS Code:

unless ENV['ANSICON'] || ENV['VSCODE_PID']

I have tested the above change with my local copy of the gem, and I am able to see the correct color output from cucumber in the VS Code integrated terminal. I figured I would share this with the community, and let you folks consider whether it is worth including in the project.

Edit: I updated the environment variable above. The previous value of VSCODE_CLI comes from running the code.bat file to launch VS Code. If you launch VS Code from the start menu, then that variable is not defined. However, VSCODE_PID appears to be a reliable indicator that you are running in the integrated terminal.

@aslakhellesoy
Copy link
Contributor

This issue was moved to cucumber/cucumber-ruby#1163

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants