Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gherkin C tests fail on Alpine Linux #165

Closed
aslakhellesoy opened this issue Mar 21, 2017 · 3 comments · Fixed by #176
Closed

Gherkin C tests fail on Alpine Linux #165

aslakhellesoy opened this issue Mar 21, 2017 · 3 comments · Fixed by #176

Comments

@aslakhellesoy
Copy link
Contributor

Summary

Approval tests (diffing golden masters) fail on Alpine Linux

Expected Behavior

I'd expect it to work just as on other Linuxes and OS X.

Current Behavior

The uri property of gherkin-document events is empty:

bin/gherkin --no-source --no-pickles testdata/good/background.feature | jq --sort-keys --compact-output "." > acceptance/testdata/good/background.feature.ast.ndjson
diff --unified <(jq "." testdata/good/background.feature.ast.ndjson) <(jq "." acceptance/testdata/good/background.feature.ast.ndjson)
--- /dev/fd/63	2017-03-21 21:27:34.586342889 +0000
+++ /dev/fd/62	2017-03-21 21:27:34.586342889 +0000
@@ -58,5 +58,5 @@
     "type": "GherkinDocument"
   },
   "type": "gherkin-document",
-  "uri": "testdata/good/background.feature"
+  "uri": ""
 }
make: *** [Makefile:89: acceptance/testdata/good/background.feature.ast.ndjson] Error 1
make: *** Deleting file 'acceptance/testdata/good/background.feature.ast.ndjson'

Possible Solution

Don't know

Steps to Reproduce (for bugs)

git clean -dfx gherkin/c
docker run -v $(pwd):/app -it cucumber/cucumber-build:1919bbc16bcd230522be530efc885b29 bash
cd gherkin/c
make .compared

Your Environment

  • Version used: HEAD of master
  • Operating System and version: Alpine Linux 3.5 running in Docker
@aslakhellesoy
Copy link
Contributor Author

Hi @brasmusson - any idea what might be causing this?

@brasmusson
Copy link
Contributor

The uri originally comes from the command line arguments, which are passed as arrays of char (as defined by the signature of main). This differs from most other data (originating from the feature files) which is read into arrays of wide-char (wchar_t). This is the angle I would explore first

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants