Cucumber expressions tree regexp #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "cucumber-expressions/java" merged: "a23cf840" upstream: origin: "https://github.com/cucumber/cucumber-expressions-java.git" branch: "master" commit: "a23cf840" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "db54757"
subrepo: subdir: "cucumber-expressions/javascript" merged: "6e948bf0" upstream: origin: "https://github.com/cucumber/cucumber-expressions-javascript.git" branch: "master" commit: "6e948bf0" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "db54757"
subrepo: subdir: "cucumber-expressions/java" merged: "f9ca1ec2" upstream: origin: "https://github.com/cucumber/cucumber-expressions-java.git" branch: "master" commit: "f9ca1ec2" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "db54757"
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Better support for nested and optional capture group
Details
This change introduces a
TreeRegexpclass, which returns matches as a tree ofGroup, which match the nested structure of capture groups in the regular expression source. Non-capturing groups are excluded.Motivation and Context
The tree structure makes it possible to access match groups with more precision than with a flat structure, and this is needed in order to support (nested) capture groups in parameter types.
How Has This Been Tested?
Lots of tests
Types of changes
Checklist: