Ads "Ukoliko" as Croatian "Given" alternative

[banovotz]

"Ukoliko" expresses the givens for the test linguistically in more natural way.

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[aslakhellesoy]

Thanks @banovotz! Can you add a space after the new keyword please?

[xtrasimplicity]

(As we release these changes, we'll also need to update the gherkin dialects table here: https://docs.cucumber.io/gherkin/reference :))

…

On Wed., 19 Sep. 2018, 08:09 Aslak Hellesøy, ***@***.***> wrote: ***@***.**** requested changes on this pull request. Thanks @banovotz <https://github.com/banovotz>! Can you add a space after the new keyword please? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#480 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI4pzZmNdNIP6XlUlj-WhTPXNmj2vu2Iks5ucW8MgaJpZM4WtkBL> .

[banovotz]

Thanks @aslakhellesoy Space added.

[aslakhellesoy]

Hi @banovotz,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[aslakhellesoy]

Thanks for merging @xtrasimplicity.

Whenever you merge a PR, please update the changelog accordingly, following the conventions alteady present.

[xtrasimplicity]

Woops, sorry! I'll do that as soon as I can. :)

…

On Tue., 25 Sep. 2018, 04:52 Aslak Hellesøy, ***@***.***> wrote: Thanks for merging @xtrasimplicity <https://github.com/xtrasimplicity>. Whenever you merge a PR, please update the changelog accordingly, following the conventions alteady present. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#480 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AI4pzSrxUVOoyeSOKvq3MHiBM58boqMKks5ueSoFgaJpZM4WtkBL> .

[banovotz]

Thanks guys for inviting me to Cucumber core team :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.