Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve German translation #707

Closed
Haukinger opened this issue Sep 24, 2019 · 4 comments
Closed

Improve German translation #707

Haukinger opened this issue Sep 24, 2019 · 4 comments

Comments

@Haukinger
Copy link

There's a pull request (352) that improves the German translation by replacing the atrocious "Szenariogrundriss", but it seems to have been closed and ignored.

Any chances for merging that one or perhaps a new pull request?
@aslakhellesoy
Copy link
Contributor

Hi @Haukinger - looks like #352 was accidentally made against gherkin/c/gherkin-languages.json rather than the master at gherkin/gherkin-languages.json. It was merged, but later overwritten by the master (our build system does this).

Could you please send a new PR against the correct file? Thanks!

@Haukinger Haukinger mentioned this issue Sep 24, 2019
Merged
@Haukinger
Copy link
Author

No problem at all, I hope this will make it into Specflow at some point in time. I'll create an issue over there as soon as it's merged here.

@aslakhellesoy
Copy link
Contributor

Vielen Dank @Haukinger!

aslakhellesoy added a commit that referenced this issue Sep 25, 2019
@aslakhellesoy
Attribution for #352,#707,#708. Copy dialects.
307034a
@aslakhellesoy
Copy link
Contributor

Closed by #708

@Haukinger Haukinger mentioned this issue Apr 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aslakhellesoy @Haukinger