Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output parameter types in message stream #835

Merged
merged 4 commits into from Dec 25, 2019
Merged

Conversation

aslakhellesoy
Copy link
Contributor

Summary

Output ParameterType messages (only for user-defined ones, not built-in ones)

Motivation and Context

Can be used by reporting tools to build a glossary

How Has This Been Tested?

Manually actually. The cck has a parameter-types feature, and I inspected the NDJSON manually

@mpkorstanje
Copy link
Contributor

message ParameterType {
  // The name is unique, so we don't need an id.
  string name = 1;
  repeated string regular_expressions = 2;
  bool prefer_for_regular_expression_match = 3;
  bool use_for_snippets = 4;
}

In Cucumber-JVM the parameter type is part of the glue. This means that it can be defined and redefined for each scenario (think scenario scoped glue code). This means that the assumption that the name is unique doesn't hold.

@aslakhellesoy aslakhellesoy merged commit 5272422 into master Dec 25, 2019
@aslakhellesoy aslakhellesoy deleted the cck-parameter-types branch December 25, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants