cucumber-expressions: Handle multiple capture group regexps for matching

[gpichot]

Summary

When creating a new transform with multiple capture group regexps, cucumber fail to match expressions that are not using the first capturing regexp.

For instance, a transform with the captureGroupRegexps with the value ['red', 'yellow'] would fail to match an expression containing yellow.

Details

The matching expression is now a disjonction of all the capturing regexps using non capturing group (with (?:...)).

Motivation and Context

I had an issue when using multiple regexps for the same transform as it was only matching the first one. This commit fix it.

How Has This Been Tested?

I added one test that use the second regexp of the captureGroupRegexps option of a transform (and that is not matching a subset of the first regexp).

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[aslakhellesoy]

Thanks for this! I'll merge it as after I've implemented a Java and Ruby implementation too.

[aslakhellesoy]

What a great patch @gpichot - really well done.

[gpichot]

Thanks for the merge @aslakhellesoy ! :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.