Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gherkin-perl: Update Perl Gherkin implementation #1286

Merged
merged 5 commits into from Jan 10, 2021
Merged

gherkin-perl: Update Perl Gherkin implementation #1286

merged 5 commits into from Jan 10, 2021

Conversation

ehuelsmann
Copy link
Contributor

Summary

Updates the Perl Gherkin implementation

Details

The Perl Gherkin implementation was stale in the following aspects:

  1. New test cases had been added which the Perl implementation failed
  2. The Rule keyword had been added which the Perl implementation wasn't adapted for yet
  3. Gherkin JSON changed (because the project switched to protobuf-serialized-to-JSON)

This PR fixes all three aspects.

How Has This Been Tested?

The PR has been tested using the standard make tests.

Types of changes

  • Bug fix (change which un-breaks the implementation).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change does not require a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@ehuelsmann
Copy link
Contributor Author

ehuelsmann commented Jan 5, 2021 •
edited

With this patch:

$ git diff
diff --git a/gherkin/Makefile b/gherkin/Makefile
index 3942a780..dc5570c9 100644
--- a/gherkin/Makefile
+++ b/gherkin/Makefile
@@ -1,2 +1,2 @@
-LANGUAGES ?= go javascript ruby java elixir
+LANGUAGES ?= perl go javascript ruby java elixir
 include default.mk

This branch builds successfully under make docker-run with the latest docker development image -- including gherkin-perl.

@ehuelsmann
Support Rule and Scenario Outline changes in Perl
83d7a60
@ehuelsmann
Fix new scenarios in tokenizer tests
440f1d8
@ehuelsmann
Fix the AST builder for the changes in the grammar
5859e2c 
Some tokens have their underscores stripped. Nesting of the elements in the
result document is different from before and there's now a Rule element
to be supported.
@ehuelsmann
Generate predictable ID and set 'uri' in gherkinDocument
8795a43 
While at it, return a full AST instead of just the gherkinDocument
content (which introduces the need to wrap of the return value later).
@ehuelsmann
Include Rule support and the new AST structure in Pickle generation
f3781ec
@ehuelsmann ehuelsmann merged commit 5a23af9 into cucumber:master Jan 10, 2021
@ehuelsmann ehuelsmann deleted the update-perl branch January 10, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
language: perl library: gherkin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ehuelsmann